will vuong
e7a3e39f9b
Better place to capture pool.Wait metric ( #831 )
...
@wvuong Thanks. Yes, that is better.
8 years ago
Brett Wooldridge
1a6dc211dd
Fixes#821 If a disconnection class exception is thrown, do not set the flag that
...
indicates that checkDriverSupport() is complete.
8 years ago
Will Vuong
41900e07aa
Fix PrometheusMetricsTrackerTest
8 years ago
Will Vuong
d875e838c3
pool.Wait metric doesn't include timed out requests
...
We noticed that the pool.Wait metric only captured the timings for successful connection requests and doesn't capture when a connection request times out.
I didn't want to mess with IMetricsTrackerDelegate.recordBorrowStats() so I created a recordBorrowTimeoutStats() and implementation in MetricsTrackerDelegate instead. Feel free to tweak to your liking.
8 years ago
Brett Wooldridge
5c8b359b17
Add warning suppression.
8 years ago
Brett Wooldridge
2f31939cae
Add warning suppression.
8 years ago
Brett Wooldridge
0ab35e7445
Minor cleanup.
8 years ago
Brett Wooldridge
2414ebdaa4
Queue immediate replacement of retired maxLifetime connection.
8 years ago
Brett Wooldridge
8c7033a335
Fixes #742 Add MXBean accessors to HikariDataSource to facilitate
...
implementation of "graceful" shutdown when JMX is not enabled.
8 years ago
Brett Wooldridge
ef7da7dad4
Minor cleanup.
8 years ago
Brett Wooldridge
b2cd44f97d
Remove deprecated method call.
8 years ago
Brett Wooldridge
ea3043dea2
Fixes #817 restore former failfast=false behavior by completely
...
bypassing the connection validation if initializationFailTimeout is
negative.
8 years ago
Brett Wooldridge
8433e8bd53
Remove unused classes.
8 years ago
Brett Wooldridge
243490773b
Move TestFastList, add iterator test.
8 years ago
Brett Wooldridge
1587198e6a
Change the internal handling of the initializationFailTimeout.
8 years ago
Brett Wooldridge
a2717e565b
Fix race condition edge case.
8 years ago
Brett Wooldridge
d9cc246342
Minor cleanup.
8 years ago
Brett Wooldridge
75b697a25c
Cleanup.
8 years ago
Brett Wooldridge
b06eb02b6d
MetricsTracker refactor.
8 years ago
Brett Wooldridge
8bb6d1e525
DRY.
8 years ago
Brett Wooldridge
907da6a2cc
Fixes #793 introduce new methods for scheduled executor service that
...
takes/returns ScheduledExecutorService interface instances.
8 years ago
Brett Wooldridge
b932b67ddb
Fixes #803 Fix javadoc and re-signal interrupted flag.
8 years ago
Brett Wooldridge
033855209e
ClockSource cleanup (Java 8'ification); makes everything more readable
...
due to static import ability.
8 years ago
Brett Wooldridge
eedaf8c13f
Minor cleanup.
8 years ago
Brett Wooldridge
ae553ceee4
Remove unneeded check, total connections are now calculated
...
differently.
8 years ago
Brett Wooldridge
72e862d298
Fix race condition regression in ConcurrentBag and various other cleanup.
8 years ago
Brett Wooldridge
f0b3c520c9
Great simplification of the ConcurrentBag using a direct handoff queue
...
(SynchronousQueue) with a huge performance win (1.8x) for contended
pool access and at least 25% for non-contended access.
8 years ago
Brett Wooldridge
9efa2f7098
Add a Tomcat web application ClassLoader/ThreadLocal leak detection test.
8 years ago
Brett Wooldridge
5544a7113f
Improved ThreadLocal handling using Java 8 Supplier for initial value.
...
Hope this does not trigger Tomcat’s ClassLoader leak detection.
8 years ago
Brett Wooldridge
a3386d080e
Performance tweak, only signal if there are threads waiting.
8 years ago
Brett Wooldridge
4a454a4e9e
Fixes #614 Add the connection created during checkFailFast() to the pool
...
unless minimumIdle=0.
8 years ago
Brett Wooldridge
becaae4554
Unit test cleanup (lots of static imports). Also, the pool name will be set to the
...
method name of the test automatically (where possible).
8 years ago
Brett Wooldridge
61ddcb41eb
Additional unit test.
8 years ago
Brett Wooldridge
1cf7457168
Remove unneeded code. This is now handled in PoolBase.newConnection().
8 years ago
Brett Wooldridge
ceffabb39f
Cleaner pool configuration debug logging.
8 years ago
Brett Wooldridge
c3ef9ba062
Close#801 Additional changes, including eliding the submission of a new
...
PoolEntryCreator to the addConnectionExecutor when there are
already enough queued tasks to cover number of pending waiters.
8 years ago
shendley
f75f0e353a
#776 re-introduce the check on number of waiters just before connection creation time
8 years ago
shendley
f0bc58279d
#776 updated thread vs connection test to gather total and maxActive when there is no work to do to verify that we don't add any extra connections
8 years ago
Brett Wooldridge
8f84e1fb12
Fix build break.
8 years ago
Brett Wooldridge
45d33c0345
Build break fix
8 years ago
Brett Wooldridge
657de54b48
Change to bound check instead of exception trap
8 years ago
Brett Wooldridge
393ca0a7e6
Recycle connection if thread is interrupted after acquisition.
8 years ago
Brett Wooldridge
a3173c51ca
Handle all exception types.
8 years ago
Brett Wooldridge
bfcb95ae75
Remove deprecated API usage
8 years ago
Brett Wooldridge
c2f1a40a1d
Fixes #791 fix interrupted thread handling
8 years ago
Brett Wooldridge
579597aae9
Fixes #770 #786 added additional handling in HikariDataSource.getConnection(),
...
and added unit test.
8 years ago
Brett Wooldridge
df2d3e66a1
Fixes #770 added additional handling in HikariDataSource.getConnection()
...
and improved JavaDoc.
8 years ago
Brett Wooldridge
5c1bbe6bc9
Cleanup registration of Prometheus metrics (by unregistering on close()).
8 years ago
Brett Wooldridge
14b11c025c
Cleanup Java IDE warnings in tests.
8 years ago
Brett Wooldridge
fbe1006486
Fixes #770 by adding a new property initializationFailTimeout and deprecating
...
initializationFailFast.
8 years ago
Brett Wooldridge
980d8dc2e0
Fixed #781 Log before and after startup/shutdown.
8 years ago
Brett Wooldridge
9cc1fbcfca
Remove unused code from interim development.
8 years ago
Brett Wooldridge
346a2f5977
Fix bug introduced by f129797
, plus some minor cleanup.
8 years ago
shendley
18077768d1
add a "Connect" histogram metric for tracking how many and how long connections are taking #518 and #769
8 years ago
shendley
f129797b8b
Fixes #774 Merged changes from @samhendley with modifications.
8 years ago
Brett Wooldridge
7bab1a8ccd
Fixes #770 by adding a new property initializationFailTimeout and deprecating
...
initializationFailFast.
8 years ago
Brett Wooldridge
e3b79ee044
Fixes #770 by adding a new property initializationFailTimeout and deprecating
...
initializationFailFast. Exception path still needs some work… coming in the
next commit.
8 years ago
Martin Stříž
1bd23423b9
Cancel HouseKeeper task on pool shutdown ( #741 )
...
Periodic house-keeping task is scheduled during construction of
HikariPool. The resulting scheduled task is not stored and therefore it
is not cancelled during pool shutdown.
With standard behaviour, when executor is managed by HikariPool itself,
it is not an issue, because the executor is shut down on pool shutdown.
But when a custom (long running) scheduled executor is supplied via
setScheduledExecutorService, tasks are kept indefinitely causing a
memory leak.
9 years ago
Brett Wooldridge
8361cf5afe
Fix stability of HikariCPCollectorTest for travis-ci build
9 years ago
Brett Wooldridge
ac08f5c16b
Cleaner pool size accounting.
9 years ago
Brett Wooldridge
b84f0df071
Minor cleanup
9 years ago
Johno Crawford
9b7cdb849b
Check the correct sql state and error code when unwrapping the exception chain. ( #724 )
9 years ago
Johno Crawford
135fb0bc5d
Unwrap chained exceptions. ( #723 )
...
good catch
9 years ago
Brett Wooldridge
5e05adcd27
Fixes #719 only reset lastConnectionFailure after a successful dataSource.getConnection() call.
9 years ago
Brett Wooldridge
6bff298316
Provisional fix for #714
9 years ago
Brett Wooldridge
20e6a5d923
Fixes #716 do not scan deeper than 10 nested SQLExceptions, it's typically a trap ... a chain that never terminates.
9 years ago
Brett Wooldridge
15ef1bd290
Misc. compiler warning cleanups. Still quite a few remaining in the tests...
9 years ago
Brett Wooldridge
d16f4eee5b
Fix test failure caused by reformatting code
9 years ago
Brett Wooldridge
d5cb614639
Fix test failure caused by reformatting code
9 years ago
Brett Wooldridge
b343eb8ae1
Remove compiler warnings
9 years ago
ams2990
115453a282
Change what character is used for microseconds ( #707 )
...
Currently, it uses GREEK SMALL LETTER MU (U+03BC), which doesn't display in the command prompt on Windows. After this commit, it uses MICRO SIGN (U+00B5).
9 years ago
Brett Wooldridge
a8a926be09
Closes #701 Ensure the exception type is the same as 2.3.x
9 years ago
Brett Wooldridge
bb86c38ac1
Add comment re: issue #701 to prevent accidental breakage of Spring Boot's FailureAnalyzer.
9 years ago
Jack
53d479cf03
added remove of ConnectionTimeoutRate and refactored metric names into constants ( #698 )
9 years ago
Brett Wooldridge
5f3c97702f
Handle non-string properties
9 years ago
Brett Wooldridge
aabc47737f
Minor Java 8 changes
9 years ago
Brett Wooldridge
6c3957b04b
Minor cleanup
9 years ago
Brett Wooldridge
52d1c9fb52
Minor Java 8 changes
9 years ago
Brett Wooldridge
cce7c9133d
Prepare 2.5.0 release (Java 8 only)
9 years ago
Brett Wooldridge
03122e85b4
Fixes #696 use iteration instead of recursion to avoid a stack overflow with deeply nested SQLExceptions
9 years ago
Brett Wooldridge
6edaa336a6
CHANGES log and cleanup.
9 years ago
Brett Wooldridge
97057a1696
Fixes #694 report if a previously reported leaked connection is returned to the pool
9 years ago
Brett Wooldridge
c295eae960
Fixes #689 log a warning if default transaction isolation level cannot be detected.
9 years ago
Brett Wooldridge
6f81b02b32
Workaround for Apache Derby bug where the connection cannot be closed while a transaction is active.
9 years ago
Brett Wooldridge
fa0a3e3b6f
resolved #691 Remove additional check.
9 years ago
Brett Wooldridge
60224a0399
Fixes #674 fix regression caused by pull request #450 (overzealous optimisation)
9 years ago
puntogil
ddfe0ab6cb
Add license headers ( #688 )
9 years ago
Brett Wooldridge
e6ece36c32
Merge commit '953b0be06d7517e63eebb6ef61c6d734621eae1e' into dev
9 years ago
TestSuiteReductionResearch
ed2cce6eda
Ignoring test that is redundant for com.zaxxer.hikari.pool.TestConnectionTimeoutRetry.testConnectionRetries ( #678 )
9 years ago
Johno Crawford
3bf8356b8d
Implement List directly instead of extending ArrayList. ( #680 )
...
* Implement List directly instead of extending ArrayList.
* Remove transient dependencies.
* Support serialization.
9 years ago
Nitin
953b0be06d
test for failure in case of InitializationFailFast
9 years ago
Brett Wooldridge
54c1cbaeae
Fix incorrect parameter order in thread starvation warning.
9 years ago
Nitin
15468fb4bd
fix comments
9 years ago
Nitin
3716edfa57
fix test
9 years ago
Nitin
9a868bd4b0
consistency cleanup, renamed requite and releaseConnection to recycle
9 years ago
Brett Wooldridge
eb65b1b233
Fixes #664 do not recycle (requite) PoolEntrys that have been closed.
9 years ago
Brett Wooldridge
fb95531f07
Update ProxyConnection.java
...
Fixes #661 add error code
9 years ago
Brett Wooldridge
dd0c82613c
Minor cleanup.
9 years ago
Brett Wooldridge
21eedd5502
Fixes #650 detect Amazon Redshift connection refused error code.
9 years ago
Brett Wooldridge
211bcd4657
Specify floating point accuracy.
9 years ago
Nitin
5cbb9351f8
Cherry-picked pull requests, added better Java 8+ detection.
9 years ago
Tokuhiro Matsuno
76cf343c8b
Add prometheus support ( #632 )
9 years ago
Johno Crawford
7d1fb2ea3a
PropertyBeanSetter uses default locale ( #643 )
...
Motivation:
toUpperCase works according to Locale settings, for example if your computer locale is Turkish, "idleTimeout" property turns into "setİdleTime" beacuse upper "i" is "İ" in Turkish.
Modifications:
Invoke toUpperCase with Locale.ENGLISH.
Result:
Fixes #641 .
PropertyBeanSetter should work with Turkish locale.
9 years ago
Johno Crawford
88e6c7b580
Shutdown will throw NPE if invoked from checkFailFast ( #621 )
...
Motivation:
Shutdown may be invoked as a result of checkFailFast failing resulting in an NPE as the executors are setup later in the constructor.
Modifications:
Add null checks before trying to shutdown the executors.
Result:
"Graceful" shutdown.
9 years ago
Brett Wooldridge
8dde168adb
Possibly Fixes #606 Fixes ##610 housekeeper was running before all class members were initialised leading to an NPE in the housekeeper. Whether or not a particular VM would recover depends somewhat on its memory model. The pool on OS X did recover after the initial failure.
9 years ago
Emilio Lopez Gabeiras
50ce1a1acc
Add ORA-02399: exceeded maximum connect time to SQL_ERRORS.
...
Not handling it avoids eviction of the connection and corrupts the pool.
For example the following NullPointerException is thrown when trying to use the pool afterwards:
java.lang.NullPointerException at com.zaxxer.hikari.pool.PoolBase.isConnectionAlive(PoolBase.java:128)
at com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:171)
at com.zaxxer.hikari.pool.HikariPool.getConnection(HikariPool.java:147)
at com.zaxxer.hikari.HikariDataSource.getConnection(HikariDataSource.java:99)
.......
9 years ago
Brett Wooldridge
a10034ca43
Merge branch 'dev' of https://github.com/brettwooldridge/HikariCP into dev
9 years ago
Brett Wooldridge
668315c5de
Fixes #596
9 years ago
Brett Wooldridge
db989fff2d
Merge pull request #590 from mtambara/concurrent
...
Add test to demonstrate concurrency problem
9 years ago
Brett Wooldridge
610ea712ef
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
Brett Wooldridge
ed60109dcc
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
Brett Wooldridge
09ab4fbfa7
Fixes #594 store unique pool number as a String in the global system properties.
9 years ago
Brett Wooldridge
15037cc156
time-out was too tight and causing sporadic travis-ci failures.
9 years ago
Brett Wooldridge
5c8248732b
Paternalistic fix for developers with a weak grasp of resource ownership.
9 years ago
Brett Wooldridge
5eebe56dd1
Fixes #591 Synchronise the track statement method, and clearing of the tracked statement list.
9 years ago
Brett Wooldridge
21357a6b08
Fixes #591 Synchronise the untrack statement method to ensure that Statements are independently thread-safe.
9 years ago
Brett Wooldridge
bd96f1cca4
Fixes #593 This is a very common condition rather than an "exceptional" one, so log at information level and do not classify as a "failure".
9 years ago
Matthew Tambara
d59771cd16
Add test to demonstrate concurrency problem
9 years ago
Nitin
6ed3b18591
small but important fixes
...
removed var
removed resetting, delink validationTimeout from connectionTimeout
one less ref per leak task. renamed start() to schedule()
made some fields final
init of leakDetectionThreshold is not required for other instances
toString using elapsedDisplayString
fix: update poolEntry.lastBorrowed in case NopMetricsTrackerDelegate
fix tests.. try1
setting isCommitStateDirty conditionally in setAutoCommit()
again, avoid calling getNextException :)
setting lastAccess in close()
setting lastAccess required only in ctor and close
removed borrowed time from PoolEntry#toString()
now that lastAccess is moved to close(), moved condition too
one less call to System.nanoTime()
fix. using toNanos()
reverted toNanos() change, got too cumbersome
removed two calls to system time
timeout is not clock time :)
only one call saved but precise 'time taken to borrow'
unlink validation of connectionTimeout with maxLifetime
Merge
Revert
9 years ago
Brett Wooldridge
fc1aea9609
Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
Nitin
e4b91287cb
simplified call to executeSql()
9 years ago
Nitin
c7e3a8f6cc
moved validateNumerics(), last in validation and is not throwing any
...
exception
9 years ago
Guido Medina
bf83c624ed
IntelliJ inspections fixes, Maven dependencies and plugins updated to latest stable.
9 years ago
Nitin
1b1b63fb3e
renamed ProxyLeakTask as it has nothing to do with 'proxy'
9 years ago
Nitin
a6486c6417
fix: set last access even for readonly and set isCommitStateDirty wisely
9 years ago
Nitin
4065283619
better variation
9 years ago
Nitin
9d34443031
bug fix: do not call next exception if delegate == closed
9 years ago
Nitin
1a9494596f
test failure fix 3
9 years ago
Nitin
5a41fee89b
test failure fix 2
9 years ago
Nitin
5238d2d4c4
fix test failure
9 years ago
Nitin
bd3e570192
added, corrected validation and test
9 years ago
Nitin
3095b6dc9e
avoid re-setting twice in validation
9 years ago
Nitin
7b1301eeec
removed unused import
9 years ago
Nitin
47ac982cc3
create leak task first and reverted long to int change
9 years ago
Nitin
2e5dd85133
replaced volatile long with int and import static TimeUnit.*
9 years ago
Nitin
0f75311732
using UNINITIALIZED
9 years ago
Nitin
2b6da07d26
cleanup
9 years ago
Nitin
82f7c15ace
changes as suggested
9 years ago
Nitin
838d929067
using 'Failed' like every where else, instead of 'Unable'.
9 years ago
Nitin
6436870bea
separate validationTimeout and connectionTimeout and validation, init
...
networkTimeout only once.
9 years ago
Brett Wooldridge
6e06620976
I didn't like this change, but missed it in the review. Readability over performance in this case. Not to mention that the JVM is likely to hoist the instanceof check and cast out of the loop because it is final invariant.
9 years ago
Brett Wooldridge
1f244af32f
Issue #547 Cleanup and additional logging.
9 years ago
Brett Wooldridge
fb09f10298
Log a warning (once) when it is not possible to honor a validation timeout of less than 1 second.
9 years ago
Brett Wooldridge
0e3677afa3
Use same terminology as other validation log messages, ie. "is less than" or "is more than".
9 years ago
Brett Wooldridge
6b535d542d
Merge branch 'dev' of github.com:nitincchauhan/HikariCP into dev
9 years ago
Nitin
e46034f56d
bugfix: calling sValid() with 0 is infinite. made minimum 1sec
9 years ago
Brett Wooldridge
62fdb2c6c3
Merge pull request #567 from nitincchauhan/dev
...
avoid 'more' exceptions after 'un-recoverable' exception thrown before for the connection
9 years ago
Nitin
e7da3f5dc7
reverted as suggested
9 years ago
Nitin
0d0eec16ea
moved check to call(), start thread in other loop
9 years ago
Nitin
14ceda3b0c
for re-throwing exception, setting log level to error
9 years ago
Nitin
4c2486e4a0
removed static log, like parent PoolBase. checking instanceof out of
...
loop
9 years ago
Nitin
a007e730be
race test: exit loop on exception
9 years ago
Nitin
d3bc0a155a
it is 1 thread so have queue size that mostly do not require to queue
...
jobs on caller
9 years ago
Nitin
3610590d64
poolName was missing in few logs
9 years ago
Nitin
ba09a68fe1
better thread names and log in validateNumerics() with poolName
9 years ago
Nitin
f46fc1e9e5
setting allowCoreThreadTimeOut first
9 years ago
Nitin
8bece2de76
consistent name for threads
9 years ago
Nitin
c2523133d4
over-riding method instead of passing true as default from other places
9 years ago
Nitin
2bc3d98901
unique 'closing' reason for each situation
9 years ago
Nitin
76d490d2de
removed explicit call to fillInStackTrace()
9 years ago
Nitin
ce03fc68c9
removed word 'pool' from thread name
9 years ago
Nitin
e156b0d719
removed misleading 'extra' comma
9 years ago
Nitin
9936e95afe
moved log 'closed' at the very end
9 years ago
Nitin
f23f358ad4
avoid 'more' exceptions after connection is detected throwing
...
un-recoverable exception
9 years ago
Brett Wooldridge
e350d1f15f
Issue #566 Remove separate Counter metric for timeouts, count is implicitly captured and available from the new Meter metric for timeout rates.
9 years ago
Will Vuong
85a298ccc6
Add metric for recording count and rate of connection timeouts
9 years ago
Brett Wooldridge
65e23b102a
Merge pull request #550 from ash2k/improvements2
...
Improvements2
9 years ago
Brett Wooldridge
4a5ffcdd05
Merge pull request #556 from Shredder121/timing-windows
...
Skip the `testMetricUsage` test on Windows
9 years ago
Brett Wooldridge
68a52f1431
Merge branch 'dev' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
Brett Wooldridge
6f49960d13
Spelling and naming.
9 years ago
Brett Wooldridge
852bbff2ad
Minor logging changes.
9 years ago
Brett Wooldridge
91ad77b142
Don't assume 'now' is in milliseconds ... it's probably nanoseconds on most platforms.
9 years ago
Brett Wooldridge
7dfdf597e2
Because housekeeper runs immediately now, 'previous' timestamp must be initialised as if it has run before, otherwise retrograde detection triggers.
9 years ago
Brett Wooldridge
e2f1974dc9
Add null check.
9 years ago
Brett Wooldridge
69dbe20cff
Issue #559 Adjust illegal clock motion detection, use scheduleWithFixedDelay() for housekeeper, and enlarge closeConnectionExecutor queue.
9 years ago
Nitin
b78fde9121
full stop :)
9 years ago
Nitin
96c91d549a
disable leakDetectionThreshold if not valid.
9 years ago
Nitin
0e3f0eb0f6
leakDetectionThreshold should be less than maxLifetime
9 years ago
Brett Wooldridge
d4d6d759de
Issue #547 Decreased allowable minimum connectionTimeout and validationTimeout to 250ms.
9 years ago
Brett Wooldridge
bd7e3ba6db
Issue #563 Do not start the house-keeping thread until after pool initialisation has completed.
9 years ago
Nitin
2b0e3f7553
changed log level: warn instead of debug, during driver support check
...
(logs only once)
9 years ago
Brett Wooldridge
f7c8118a86
Issue #559 cap the number of connections added by fillPool() if there are already pending tasks to do so.
9 years ago
Brett Wooldridge
91dbe31ff2
Fixes #559 improve logging of time shifts, allow retrograde time adjustments
9 years ago
Nitin
4f865cabb5
do not set maxLifetime when disabling idle timeout
9 years ago
Nitin
f40a13b5be
added synchronized to getObjectInstance()
9 years ago
Nitin
a40e4856c9
renamed method to checkDriverSupport() and query driver default
...
transaction isolation once
9 years ago
Ruben Dijkstra
8adf36bc3d
Skip the `testMetricUsage` test on Windows
...
My 75th percentile is indeed 250ms, but _sometimes_ returns 249ms
9 years ago
Brett Wooldridge
c0bd8bfeac
Fixes #555 check for default method is not longer needed because proxy generation is performed at build-time not run-time now.
9 years ago
Nitin
99cacb33b2
changes as suggested. reverted resetBits and method.getParameterCount()
9 years ago
Brett Wooldridge
73491abb31
Fixes #555 check for default method is not longer needed because proxy generation is performed at build-time not run-time now.
9 years ago
Nitin
573660dfe1
future safe from statement reorder
9 years ago
Nitin
64dd93fe8f
minor
9 years ago
Nitin
85e41abf10
context.close is correct. 542 may have other reason/s!
9 years ago
Nitin
b525e0f7ef
set maxPoolSize = minIdle only if undefined, consistent error messages
9 years ago
Nitin
ad754d085b
made transactionIsolation final
9 years ago
Nitin
fde88d0659
if user specified, set transaction isolation level
9 years ago
Nitin
ce50c2cfd6
removed resetBits. setting transaction isolation level like readonly &
...
autocommit.
9 years ago
Nitin
c8cd7ab1bb
swap test condition
9 years ago
Nitin
9a63ebf876
replaced getParameterTypes().length with getParameterCount()
9 years ago
Mikhail Mazurskiy
743dc09d9a
Slightly improve generics
9 years ago
Mikhail Mazurskiy
a30dcd87b8
Cache volatile reads in local variables
...
Avoid unnecessary read memory barriers
9 years ago
Mikhail Mazurskiy
c3dcb08023
Preserve tread interrupted status
9 years ago
Nitin
aa90bd62e0
close statement before commit/rollback
9 years ago
Nitin
6769539f10
close ds
9 years ago
Nitin
23b4909155
sizing queue for connection closing proportionally
9 years ago
Nitin
c362e8bb35
fixed test
9 years ago
Nitin
9daa51313f
I've added context.close() before but not sure anymore! see 542
9 years ago
Nitin
87757fcd0a
keeping connectionBag.remove and totalConnections.decrementAndGet()
...
close by
9 years ago
Nitin
5f851a4cfb
reverted. using cachedExecutor for setting network timeout as before
9 years ago
Nitin
c9ad521660
cleanup + rearrange statements
9 years ago
Nitin
2f3a1079ed
merged DefaultThreadFactory with UtilityElf
9 years ago
Nitin
cf1b7738c0
unused import
9 years ago
Nitin
a56f5dcb2d
removed ThreadPoolExecutor for use with setNetworkTimeout
9 years ago
Brett Wooldridge
1a64ab2357
This change in incorrect. Even the pure JDBC4 isValid() check can execute a query, and it is known that some drivers do so.
9 years ago
Brett Wooldridge
77e5972005
Fix for Java 7.
9 years ago
Brett Wooldridge
a270577dc3
Merge branch 'dev1' of https://github.com/nitincchauhan/HikariCP into dev
9 years ago
Nitin
5c39c0a462
cache and refresh 'volatile' validationTimeout too
9 years ago
Nitin
c7652d6ef9
optimize isConnectionAlive() replaced getAndSetNetworkTimeout with
...
setNetworkTimeout
9 years ago
Nitin
6124110d86
revert to setting network time out in try. in case it throws
9 years ago
Nitin
fd02583e47
minor tweaks
9 years ago
Nitin
787bd979eb
better property logging
9 years ago
Nitin
211e8e5d50
special treatment for password
9 years ago
Nitin
d3d5dd6414
null check with instanceof is redundant
9 years ago
Nitin
9bb262cb23
reverted nullifying
9 years ago
Nitin
705c9e7db5
nullify in condition
9 years ago
Nitin
ce4ff9255b
fixed NPE in tests
9 years ago
Nitin
3d2a082da8
do NOT recycle connection that is evicted in checkException()
9 years ago
Nitin
5321da3f50
better closure reason
9 years ago
Nitin
9168b83377
false warning, removed.
9 years ago
Nitin
60e272614e
re-setting isIsolateInternalQueries if not required
9 years ago
Nitin
2bd02091b4
reverted: setting lastConnectionFailure to null
9 years ago
Brett Wooldridge
48a8afd141
Fixes #495 implement iterator for Tomcat leak detection.
9 years ago
Nitin
926167598a
Fixed Test
9 years ago
Nitin
1e24d50f97
make sure pool is ready before reseting counter
9 years ago
Nitin
4ec2e80c1e
reset StubConnection.count after pool initialization
9 years ago
Nitin
b88b314adc
fixed tests :)
9 years ago
Nitin
18c0e2d6b0
assertion with text
9 years ago
Nitin
af93c99019
set Sleepbackoff time to maximum 10 seconds
9 years ago
Nitin
cd24a1e024
fixed errors
9 years ago
Nitin
60b58ad63d
minor cleanup in tests
9 years ago
Nitin
95b237a07f
more debug
9 years ago
Nitin
625b9d77dd
added poolname to debug
9 years ago
Nitin
fc09055538
minor cleanup
9 years ago
Nitin
8277a55c58
fixed test
9 years ago
Nitin
5ff7a72127
fixed tests
9 years ago
Nitin
cb16120753
fixed test failures
9 years ago
Nitin
b60f166681
minor cleanup
9 years ago
Nitin
8908411e41
for initializationFailFast, fail asap, not wait till connectionTimeout
9 years ago
Nitin
5a2d40879e
keep lastConnectionFailure till getAndSet
9 years ago
Nitin
4b2e1d9ea5
removed explicit use of iterator
9 years ago