29eb681cbb
Handle short in PropertyElf ( #1581 )
4 years ago
00f5f202a4
Due to change in JDK-11 and later in ThreadPoolExecutor.java, setMaximumPoolSize needs to be done before setCorePoolSize, the current implementation throws IllegalArgumentException and hence prefilling of connections by setting com.zaxxer.hikari.blockUntilFilled is broken. ( #1605 )
...
Co-authored-by: rampr_000 <spachanady@gmail.com>
4 years ago
5efab340e8
Refine JMX ObjectName ( #1681 )
...
fix https://github.com/brettwooldridge/HikariCP/issues/1678
4 years ago
d9983b32c1
Make generated proxy class final ( #1661 )
...
The final modifier is overridden by public modifier before this commit
4 years ago
b2f45a5441
Remove micrometer metrics on close ( #1700 )
...
Co-authored-by: Iouri Goussev <igoussev@xmatters.com>
4 years ago
43a3ce0aec
Fix typo in documentation from 'used' to 'use'. ( #1555 )
...
Co-authored-by: Caleb Larsen <caleb.larsen@rentping.com>
4 years ago
8217f2082d
#1582 : update module-info to mark optional dependencies as 'static' ( #1587 )
...
* #1582 : update module-info to mark optional dependencies as 'static'
* update to hibernate.core release 5.4.16.Final and use its module name
Co-authored-by: Brett Wooldridge <brett.wooldridge@gmail.com>
4 years ago
30c63c6372
Fixed optional dependencies that were marked as required in module-in… ( #1669 )
...
* Fixed optional dependencies that were marked as required in module-info.java
* * Upgraded bundle plugin to fix https://issues.apache.org/jira/browse/FELIX-6259 .
* Windows requires the use of ${file.separator} to separate classpath entries.
* Need to use a different log4j-slf4j-impl artifact under Java 11.
4 years ago
1d05b0ec67
Added missing dependencies ( #1577 )
...
* Added missing dependencies.
* Ant needs to be told which dependencies go on the classpath and modulepath.
* Removed unused classpath entry.
5 years ago
d9ee5fab69
Renamed Java9 artifact to Java11.
5 years ago
aaf4d3a59e
Added module-info.java for Java9
5 years ago
009a7013cf
Qualify yield() method as Thread.yield() (IDE warning for Java 14+), and add threadlocal removal attempt to bag item removal.
5 years ago
8df41bf748
Additional logging.
5 years ago
fe29962233
When blocking initialization is specified, use a minimum of 16 connection creation threads.
5 years ago
a51e6a07e8
Fixes #1489 allow specification of a user supplied exception eviction override class
5 years ago
aeebbdf54a
Fixes #1534 check resultSet.getStatement() for null in ProxyDatabaseMetaData.
5 years ago
93c7178012
Fixes #1528 regression in fail fast handling.
5 years ago
f5b650bb7a
Fix regression caused by #1337
6 years ago
c953243af3
Add proxy class for java.sql.DatabaseMetaData.
6 years ago
086bf18389
Refactor/fix Prometheus metrics for multiple connection pools, add unit tests ( #1331 )
...
* Refactor/fix Prometheus metrics for multiple connection pools
Changes:
* Fix "Collector already registered that provides name:
hikaricp_connection_timeout_total" error
* Register only one HikariCPCollector instance in one CollectorRegistry
instance
* Add ability to remove metrics when connection pool is shutting down
* Add/update unit tests
* Refactor/add unit tests - metrics package
* Re-format curly braces to be inline with the whole code base
6 years ago
c509ec1a3f
#1337 isolation level fix for all values accept string ( #1338 )
...
* #1337 isolation level fix for all values accept string
* #1337 name convension refactor
* #1337 remove unused comment
* review fix for redundant optional
6 years ago
efa25c3aaa
Alternative Prometheus metrics Histogram instead of locking Summary. ( #1265 )
...
* Alternative Prometheus metrics Histogram instead of locking Summary.
Add PrometheusHistogramMetricsTracker.java that uses an internal
Histogram instead of Summary. A summary is quite lock heavy.
See: https://github.com/prometheus/client_java/issues/328
* Fix incorrect magnitudes of buckets.
6 years ago
e8e9cdd00a
fixes #1287 set core pool size before max pool size
6 years ago
86612b4bc4
Do NOT default maxPoolSize to minIdle when only minIdle is specified.
6 years ago
cda2605acc
Fixes #1308 treat a SQLTimeoutException as an evictable offense
6 years ago
c742e86838
Do not log warning about idleTimeout unless minimumIdle is less than maxPoolSize (because otherwise it does not apply)
6 years ago
17447199f5
Fixes #1305 ensure that ConcurrentBag.add() does not spin under high load, when waiting threads may never reach 0.
6 years ago
1ac94f16a2
Fixes #1287 when system property blockUntilFilled is set, use multiple threads to fill the pool.
6 years ago
4333989ca2
Fixes #1305 ensure that ConcurrentBag.add() does not spin under high load, when waiting threads may never reach 0.
6 years ago
f0676c8727
Replace anonymous class with lambda ( #1292 )
6 years ago
50c3fd1b78
Call newInstance on Constructor of driverClass ( #1290 )
...
Class.newInstance is deprecated as of Java 9. Usage should be replaced by calling Class.get(Declared)Constructor.newInstance
6 years ago
45912ebb57
Fix unit test breakage.
6 years ago
239919c33d
Fix unit test breakage.
6 years ago
f005a4769f
Various clean-ups pointed out by sonarcloud.io
6 years ago
b39141bfd5
Fix for #1226 and unit tests. ( #1227 )
6 years ago
74b55aef05
Fix proxy classes generation reproducibility ( #1250 )
...
* Fix proxy classes generation reproducibility
* Replace sorting with LinkedHashSet
7 years ago
5d1ed1c678
Capability to instantiate an object based on the String class name ( #1074 )
...
It is usefull when you want to set the MetricsTackerFactory from a
property.
7 years ago
471e27ece0
Use orElseGet to delay call until necessary ( #1210 )
7 years ago
7209aabecc
allow to pass in a prometheus CollectorRegistry ( fixes #1181 ) ( #1182 )
...
* allow to pass in a prometheus CollectorRegistry
instead of always using CollectorRegistry.defaultRegistry.
* fixed some spots where the static CollectorRegistry.defaultRegistry was still accessed
* fixes some more spots where CollectorRegistry.defaultRegistry was used
7 years ago
74fa2a84e8
Log uncaught error in acquiring connection (+1 squashed commit)
...
Squashed commits:
[7a00d8bd
7 years ago
52b3811e4d
Fixes #1186 limit the number of items in the ThreadLocal list in the ConcurrentBag.
7 years ago
c1032a06df
Quasi-revert change. Some driver's implementation of isClosed() might attempt TCP, and therefore encounter unacknowledged packets outside of the network timeout protection.
7 years ago
88b57c3bd7
Check closed condition before attempting to set network timeout.
7 years ago
6a13980312
Update validation failure message.
7 years ago
603951febd
Fixes #1126 correct error in JavaDoc for HikariConfig.setInitializationFailTimeout().
7 years ago
5607d8b913
Fixes #1141 do not throw SQLException when calling isClosed() or close() on a already closed Connection, as per JDBC specification.
7 years ago
8921bb08c8
Fixes #1137 support changing user/password at runtime for DriverDataSource-wrapped driver connections.
7 years ago
851e2d4592
Fixes #1137 support changing user/password at runtime for DriverDataSource-wrapped driver connections.
7 years ago
95e0b429eb
Fixes #1136 sanitize jdbcUrl for logging.
7 years ago
b36323213f
log loaded driver when using jdbcUrl ( #1136 )
7 years ago
freafrea
sw-pachanady
Yanming Zhou
Iouri Goussev
Caleb
Prashant Bhat
Gili Tzabari
Brett Wooldridge
Aleksandr Podkutin
Enes Açıkoğlu
Vincent van Donselaar
Vikash Tiwari
Arlo Louis O'Keeffe
cyleph
Sergey Monichev
fpirson
Matt Nelson
Tom Hombergs
Jungtaek Lim
Sevket Gökay