Commit Graph

1191 Commits (22eb91b9c13d6199b900a469c56225657e76dabc)

Author SHA1 Message Date
Hidde Wieringa 22eb91b9c1
Support parsing `Duration` values in `PropertyElf` (#2266)
* Add test for new property parsing

* Add implementation

* Add changelog item
2 months ago
Brett Wooldridge 84212307e4
suppress IDE warning 2 months ago
Brett Wooldridge f54241ba87
Update README, minor code cleanup. 3 months ago
Brett Wooldridge 8dd2535de9
increase keepaliveTime variance 3 months ago
Brett Wooldridge be6594a7fc
assign default keepaliveTime of 2 minutes 3 months ago
Brett Wooldridge ec6891a08e
Expand/improve SQLExceptionOverride handling flexibility 3 months ago
imjuju c7cf4b3616
Do not treat a SQLTimeoutException as an evictable offense (#2238)
Submitters of #1308 and #1631 take note. HikariCP will no longer evict connections due to encountering ``SQLTimeoutException``. If you need to "restore" this behavior consult the pool properties ``exceptionOverride`` or ``exceptionOverrideClassName``.
3 months ago
Brett Wooldridge 60a463763c
Logging changes 3 months ago
Taeho Kim 004671d826
Don't clear isCommitStateDirty flag in setReadOnly (#1842)
When autoCommit is false, if setReadOnly is called after some queries, then closing the connection leads to dirty (transaction opened) connection being reused.
3 months ago
Zhou Yang 662847bd76
support loading properties file in unnamed resources module. (#1827) 3 months ago
Brett Wooldridge c6d1403e55
fixes#1960 allow SQLExceptionOverride to adjudicate all exceptions for eviction 3 months ago
Brett Wooldridge fb49f355db
Merge branch 'dropwizard5-metrics' of https://github.com/wholesail/HikariCP into wholesail-dropwizard5-metrics 3 months ago
Chris Hill 8f9c0b5935
Add uuid to identify connection timings (#1992)
* Adding unique identifier for connection establishment start and stop debug timings.

* Fix to print both variables
3 months ago
qxo e945214ec4
feat: threadName separator from whitespace to :/- (#2065)
thredName should not have whitespace
In most logging layout.ConversionPattern whitespace was a field separator,
so if the thredName with whitespace, then the fields was not fixed it's not friendly for logging sort , ie: sort -rnk $N
3 months ago
Yanming Zhou e58966bc09
Fix inconsistency between `isWrapperFor` and `unwrap` (#2243)
Closes GH-2237
3 months ago
Yanming Zhou 4bc96d16c2
Improve JavassistProxyFactory (#2244)
1. use `"target" + File.separator + "classes"` instead of `"target/classes"`
2. print target directory
3 months ago
Yanming Zhou aa1e138fbd
Fix the wrong configuration name in Javadoc and rename variable (#2248) 3 months ago
Brett Wooldridge 28f81da440
change default maxLifetime variance from 2.5% to 25% to further avoid mass connection die-off dips 3 months ago
Brett Wooldridge 1c13fcd7cd Fix JavaDoc error, self-closing tags not allowed. 5 months ago
Brett Wooldridge d54418061f "merged" #2126 Added Support For beginRequest and endRequest (new version) 5 months ago
Yanming Zhou 8053e39996
Create SQLExceptionOverride instance when exceptionOverrideClassName loaded (#2133)
Before this commit, exceptionOverrideClass may be loaded by different ClassLoader, and two instances are created but only the latter one is used. This commit make sure the class will only loaded once and only one instance is created.

Fix GH-2124
Fix GH-2171
5 months ago
Yanming Zhou 82c82adfda
Skip Connection::setNetworkTimeout if PoolBase::shutdownNetworkTimeoutExecutor is called (#2147)
Fix GH-2130
5 months ago
Carl Mastrangelo 4f6b295e14
Make Savepoint rollbacks mark the connection dirty (#2149)
Addresses https://github.com/brettwooldridge/HikariCP/issues/2142
5 months ago
Thomas Aregger a671b6e24d
Close connections marked as evicted instead of returning them to the pool (#2157) 5 months ago
Brett Wooldridge aeabea98b7 cherry-picked changes from pull request #2166 5 months ago
benapple d43c272f3f
add support to get and set db credentials in an atomic operation (#2189) 5 months ago
Yanming Zhou 1d173513be Eliminate network call if state get is called after set (#2199)
Fix GH-2198
5 months ago
VJ b3e6d23dc5
Consistent handling of errorCode and sqlState in timeout exception (#2226)
Co-authored-by: the-vj <one.vallu@gmail.com>
5 months ago
Brett Wooldridge 7ec98c3ee2 Minor debug logging change. 5 months ago
Brett Wooldridge f601340304 Minor debug logging change. 5 months ago
James Christian 0a6ccdb334 Only log 'Connection not added' when connection not added 1 year ago
Björn Darri Sigurðsson 3990d259a1 Fixes #2152
Duplicate connection in try with resources clause caused close() being called twice on each connection.
1 year ago
alsin 2021f90444
Don't try to cast metric registry before it is checked for null (#2076)
* Don't try to cast metric registry before it is checked for null

* Simplify the condition check

* Use previously obtained object instead of calling the same getter one more time

---------

Co-authored-by: Alexander Sinuskin <Alexander.Sinuskin.ext@deutsche-boerse.com>
1 year ago
Kwangyong Kim 5b2852e8bf
Fix #1818 Add system property for minimum login timeout, regardless of the connectionTimeout (#1820) 1 year ago
cal 8c202e4554
[cleanup] erefactor/EclipseJdt - Remove trailing whitespace - All lines (#1752)
EclipseJdt cleanup 'RemoveAllTrailingWhitespace' applied by erefactor.

For EclipseJdt see https://www.eclipse.org/eclipse/news/4.18/jdt.php
For erefactor see https://github.com/cal101/erefactor

Co-authored-by: Leo Bayer <lfbayer@gmail.com>
1 year ago
cal c37074d465
[cleanup] erefactor/EclipseJdt - Simplify lambda expression and method reference syntax (#1754)
EclipseJdt cleanup 'SimplifyLambdaExpression' applied by erefactor.

For EclipseJdt see https://www.eclipse.org/eclipse/news/4.18/jdt.php
For erefactor see https://github.com/cal101/erefactor
1 year ago
cal ddf32467f4
[cleanup] erefactor/EclipseJdt - Remove redundant super() call in constructor (#1753)
EclipseJdt cleanup 'RemoveUnnecessarySuperCall' applied by erefactor.

For EclipseJdt see https://www.eclipse.org/eclipse/news/4.18/jdt.php
For erefactor see https://github.com/cal101/erefactor
1 year ago
cal b5a4373214
[cleanup] erefactor/EclipseJdt - Evaluate without null check (#1751)
EclipseJdt cleanup 'EvaluateNullable' applied by erefactor.

For EclipseJdt see https://www.eclipse.org/eclipse/news/4.18/jdt.php
For erefactor see https://github.com/cal101/erefactor
1 year ago
Liam Sorsby d15560e9d9
[#1950] Adds support for TRANSACTION_CURSOR_STABILITY and TRANSACTION_LAST_COMMITTED (#1952)
TRANSACTION_LAST_COMMITTED - This allows a readonly user to access a row and read the last commited data while Informix has an open lock against the data.
Unlike TRANSACTION_READ_UNCOMMITTED which would also accomplish the same but would end up allowing dirty reads. This would lead to us reading data that's potentially either rolledback or never actually commited.

TRANSACTION_CURSOR_STABILITY - Cursor stability will place a lock on a row as it's fetched which ensures that the data doesn't change while the program reads the data.
Documentation for cursor stability can be found here https://www.ibm.com/docs/en/informix-servers/12.10?topic=level-informix-cursor-stability-isolation

Documentation on Informix transaction isolation levels are here https://www.ibm.com/docs/en/informix-servers/12.10?topic=database-informix-environment-variables-informix-jdbc-driver

Co-authored-by: Liam Sorsby <liam.sorsby@skybettingandgaming.com>
1 year ago
Danny Faught 43d5231c96
refactor: fix spelling (#2046)
Co-authored-by: Bruce Ricard <bricard@vmware.com>
1 year ago
Leo Bayer 2883f84654 fix comment typo 1 year ago
Nicola Isotta 53459ab55a
add support for char[] in PropertyElf (#2059)
fix #2058
1 year ago
Jeff Fang 61ac830709
Remove error log for pool initialization exception (#1660)
Co-authored-by: Jeff Fang <jeff.fang@activenetwork.com>
1 year ago
Chris Pennello 3f377c0bda
Adds support for Dropwizard 5 metrics.
But not health checks yet, though.
2 years ago
Chris Pennello 07e40c20ab
Fixes TestMetrics filter bug.
Previously, this matches implementation was ignoring the `name` passed
in and instead comparing the *literal* `"testMetricWait.pool.Wait"` to
the dynamically-created
`MetricRegistry.name("testMetricWait", "pool", "Wait")`.

This commit updates the matches implementation to instead compare the
`name` passed in.

This brings it in line with the other implementations in the same file.
2 years ago
Brett Wooldridge e4bbce7152 Close #1986 evict connection exceptions with (SQLState HY000) error code 1105. 2 years ago
Brett Wooldridge a050d81004 Cleanup maven build and modify for Java 11+ only. 2 years ago
Leo Bayer d92b50f1a1 fix test: sleep needs to be guaranteed to be greater than aliveBypassWindowMs, not just equal 2 years ago
Leo Bayer a7f9a4b2f5 Don't attempt second setNetworkTimeout call if first fails 2 years ago
Martin Steiger 601475192d
Don't log keystore passwords in DriverDataSource (#1993) 2 years ago