Fix issue with ordering of checks. Bounds should only be checked in validate().

pull/131/head
Brett Wooldridge 11 years ago
parent f875f3838c
commit 70c0e3d96b

@ -546,7 +546,7 @@ public class HikariConfig implements HikariConfigMBean
@Override
public void setMinimumIdle(int minIdle)
{
if (minIdle < 0 || minIdle > maxPoolSize) {
if (minIdle < 0) {
throw new IllegalArgumentException("maxPoolSize cannot be negative or greater than maximumPoolSize");
}
this.minIdle = minIdle;
@ -696,7 +696,7 @@ public class HikariConfig implements HikariConfigMBean
connectionTimeout = CONNECTION_TIMEOUT;
}
if (minIdle < 0) {
if (minIdle < 0 || minIdle > maxPoolSize) {
minIdle = maxPoolSize;
}

Loading…
Cancel
Save