From 527c8ce59c1c59b317618a3521ab5d4f84e08246 Mon Sep 17 00:00:00 2001 From: Brett Wooldridge Date: Tue, 25 Nov 2014 23:43:17 +0900 Subject: [PATCH] Issue #206 Throw an exception if the bag is closed, this will cause addConnection() to cleanly close the opened connection and correctly decrement the pool count. --- .../src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java | 2 +- .../src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hikaricp-java6/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java b/hikaricp-java6/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java index a513ef04..240ccb6a 100644 --- a/hikaricp-java6/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java +++ b/hikaricp-java6/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java @@ -179,7 +179,7 @@ public final class ConcurrentBag public void add(final T bagEntry) { if (closed) { - LOGGER.warn("ConcurrentBag has been closed, ignoring add()"); + throw new IllegalStateException("ConcurrentBag has been closed, ignoring add()"); } else { sharedList.add(bagEntry); diff --git a/hikaricp/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java b/hikaricp/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java index 7fa4bf36..006f258a 100644 --- a/hikaricp/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java +++ b/hikaricp/src/main/java/com/zaxxer/hikari/util/ConcurrentBag.java @@ -178,7 +178,7 @@ public final class ConcurrentBag public void add(final T bagEntry) { if (closed) { - LOGGER.warn("ConcurrentBag has been closed, ignoring add()"); + throw new IllegalStateException("ConcurrentBag has been closed, ignoring add()"); } else { sharedList.add(bagEntry);