From 36eb9d54acf267dd6fc7285484519d4f2b5beda9 Mon Sep 17 00:00:00 2001 From: Julien Boniol Date: Thu, 16 Jan 2025 16:05:10 +0100 Subject: [PATCH] Setting default value for maxIdle in HikariConfig constructor --- src/main/java/com/zaxxer/hikari/HikariConfig.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/main/java/com/zaxxer/hikari/HikariConfig.java b/src/main/java/com/zaxxer/hikari/HikariConfig.java index c902c330..3af5f1a2 100644 --- a/src/main/java/com/zaxxer/hikari/HikariConfig.java +++ b/src/main/java/com/zaxxer/hikari/HikariConfig.java @@ -116,7 +116,7 @@ public class HikariConfig implements HikariConfigMXBean healthCheckProperties = new Properties(); minIdle = -1; - maxPoolSize = -1; + maxPoolSize = DEFAULT_POOL_SIZE; maxLifetime = MAX_LIFETIME; connectionTimeout = CONNECTION_TIMEOUT; validationTimeout = VALIDATION_TIMEOUT; @@ -1127,10 +1127,6 @@ public class HikariConfig implements HikariConfigMXBean validationTimeout = VALIDATION_TIMEOUT; } - if (maxPoolSize < 1) { - maxPoolSize = DEFAULT_POOL_SIZE; - } - if (minIdle < 0 || minIdle > maxPoolSize) { minIdle = maxPoolSize; }